Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ViewModifier implementation #91

Merged
merged 6 commits into from
May 5, 2024
Merged

Add ViewModifier implementation #91

merged 6 commits into from
May 5, 2024

Conversation

Kyle-Ye
Copy link
Member

@Kyle-Ye Kyle-Ye commented May 5, 2024

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 155 lines in your changes are missing coverage. Please review.

Project coverage is 14.18%. Comparing base (e16ee45) to head (06b7f78).

Files Patch % Lines
...ore/Modifier/ViewModifier/CustomViewModifier.swift 0.00% 53 Missing ⚠️
...es/OpenSwiftUI/Core/Modifier/ModifiedContent.swift 0.00% 37 Missing ⚠️
...ftUI/Core/Modifier/ViewModifier/ViewModifier.swift 0.00% 26 Missing ⚠️
...ources/OpenSwiftUI/Core/View/View/ViewInputs.swift 0.00% 10 Missing ⚠️
...ources/OpenSwiftUI/View/Debug/TODO/ViewDebug.swift 0.00% 9 Missing ⚠️
...rces/OpenSwiftUI/Core/Modifier/EmptyModifier.swift 0.00% 7 Missing ⚠️
...ces/OpenSwiftUI/Core/View/View/ViewInputFlag.swift 0.00% 4 Missing ⚠️
...iftUI/Core/View/ViewList/ViewListCountInputs.swift 0.00% 4 Missing ⚠️
...OpenSwiftUI/Core/View/View/ViewInputBoolFlag.swift 0.00% 2 Missing ⚠️
...penSwiftUI/Core/View/ViewList/ViewListInputs.swift 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   14.50%   14.18%   -0.33%     
==========================================
  Files         196      199       +3     
  Lines        4757     4866     +109     
==========================================
  Hits          690      690              
- Misses       4067     4176     +109

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kyle-Ye Kyle-Ye merged commit 25e716d into main May 5, 2024
6 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/modifier branch May 5, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kyle-Ye @codecov-commenter